Remove empty entries automatically #9894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This defeats the purpose of the dialog. I would rather have an option to automatically always delete them |
|
The dialog was there to warn about null information being in the library. Is there anyone wanting to keep information that an entry with Back in #8096 (comment), we agreed that deleting the entries is a solution. I updated the PR link to link the issue which explains why empty entries cause a headache: #8645 |
|
Not happy about this leading to a changed on disk |
Fixed. |
|
This (now) also fixes #8645, because @Article{,
creationdate = {2022-04-05T10:41:54},
owner = {mlep},
} |
Siedlerchr
previously approved these changes
May 15, 2023
Siedlerchr
added
the
status: ready-for-review
calixtus
previously approved these changes
May 15, 2023
# Conflicts: # src/main/java/org/jabref/model/database/BibDatabaseContext.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8645.
Empty entries IMHO do not contain any information.
Exmaple for empty entries:
With a citation key or any other field, they are not empty:
This PR adds a functionality so that these entries are automatically removed while writing.
Outdated
In case they are removed, JabRef will (udate NOT) issue a warning "changed on disk". I think, this warning is OK, isn't it?
Compulsory checks